Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Sider to get a customBreakpointMap as a prop #20571

Conversation

atanasgeorgiev93
Copy link

@atanasgeorgiev93 atanasgeorgiev93 commented Dec 31, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

Please note: I raised this PR against master branch because there was no feature branch open. I'm happy to adapt the PR if that is required.

馃敆 Related issue link

Allow Configuration of breakpoints in Layout Component

馃挕 Background and solution

  1. Allow a new property breakpointMap to be passed which can define new values for the breakpoints.
  2. If that property is not passed, then breakpointMap will get the default value which is hardcoded at the moment in the component.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/layout/demo/customBreakpoints.md
View rendered components/layout/index.en-US.md

@pr-triage pr-triage bot added the PR: draft label Dec 31, 2019
@atanasgeorgiev93 atanasgeorgiev93 changed the base branch from 4.0-prepare to master December 31, 2019 11:29
@netlify
Copy link

netlify bot commented Dec 31, 2019

Deploy preview for ant-design failed.

Built with commit 8f76e1d

https://app.netlify.com/sites/ant-design/deploys/5e0b30774447f100088f62c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant