fix: 😢 Fix Tree showLine and showIcon missing icon #20196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
Deploy preview for ant-design ready! Built with commit 20f0749 |
14 tasks
afc163
commented
Dec 11, 2019
components/tree/demo/line.md
Outdated
| @@ -37,7 +37,7 @@ class Demo extends React.Component { | |||
| </TreeNode> | |||
| <TreeNode title="parent 1-2" key="0-0-2"> | |||
| <TreeNode title="leaf" key="0-0-2-0" /> | |||
| <TreeNode icon={<Icon type="form" />} title="leaf" key="0-0-2-1" /> | |||
| <TreeNode switcherIcon={<Icon type="form" />} title="leaf" key="0-0-2-1" /> | |||
There was a problem hiding this comment.
不应该用 icon 去设置 switcherIcon：#20090
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 20f0749:
|
Codecov Report
@@ Coverage Diff @@
## master #20196 +/- ##
==========================================
- Coverage 97.81% 97.81% -0.01%
==========================================
Files 286 286
Lines 7739 7735 -4
Branches 2132 2164 +32
==========================================
- Hits 7570 7566 -4
Misses 169 169
Continue to review full report at Codecov.
|
afc163
changed the title
zombieJ
reviewed
Dec 11, 2019
components/tree/demo/line.md
Outdated
| @@ -37,7 +37,7 @@ class Demo extends React.Component { | |||
| </TreeNode> | |||
| <TreeNode title="parent 1-2" key="0-0-2"> | |||
| <TreeNode title="leaf" key="0-0-2-0" /> | |||
| <TreeNode icon={<Icon type="form" />} title="leaf" key="0-0-2-1" /> | |||
| <TreeNode switcherIcon={<Icon type="form" />} title="leaf" key="0-0-2-1" /> | |||
afc163
force-pushed
the
fix-tree-show-line-icon
branch
from
97636c3
to
20f0749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
close #20192
💡 Background and solution
Caused by #20102
fixed back to
We should use
switcherIconinstead oficonto customize icon in TreeshowLinemode.📝 Changelog
showLineandshowIconmissing icon.showLine和showIcon同时开启时[+][-]图标丢失的问题。☑️ Self Check before Merge
View rendered components/tree/demo/line.md