New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 Fix Button text not align center in Chrome #20059
Conversation
Deploy preview for ant-design ready! Built with commit 721f97a |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 721f97a:
|
5a7c6e3
to
721f97a
Compare
Codecov Report
@@ Coverage Diff @@
## master #20059 +/- ##
==========================================
- Coverage 97.81% 97.81% -0.01%
==========================================
Files 286 286
Lines 7737 7734 -3
Branches 2173 2173
==========================================
- Hits 7568 7565 -3
Misses 169 169
Continue to review full report at Codecov.
|
|
||
> i { | ||
vertical-align: middle; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icon 改大到 16px 之后按 baseline 对齐就会有问题。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没意义的 解决这些问题又会产生其他新的问题 不同浏览器的处理是有差异的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以帮忙看看。
效果看上去很完美。 |
I think this reintroduces the bug that #18139 fixed. Button text is once again uncentered, especially for larger button size: |
🤔 This is a ...
🔗 Related issue link
revert solution of 05181d5
close #19972
close #20058
💡 Background and solution
排查了下面所有问题,都能对齐。
Button
withhref
prop andButton
without one appears with a small difference (about 1px) #12978Button
withhref
prop andButton
without one appears with a small difference (about 1px) #12978📝 Changelog
☑️ Self Check before Merge