Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Table filterIcon bugs #20053

Merged
merged 3 commits into from
Dec 3, 2019
Merged

fix: 🐛 Table filterIcon bugs #20053

merged 3 commits into from
Dec 3, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 3, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20049

💡 Background and solution

  1. Fix Tooltip在Table的FilterIcon下不显示正确的title内容 #20049
  2. Fix filterIcon render string or number or null will throw error.

📝 Changelog

Language Changelog
🇺🇸 English - Fix Table filterIcon throws error when render string or number.
- Fix Table filterIcon show wrong title when returns Tooltip.
🇨🇳 Chinese - 修复 Table filterIcon 返回字符串或数字时报错的问题。
- 修复 Table filterIcon 返回 Tooltip 时显示了错误的 title

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/table/demo/custom-filter-panel.md

@netlify
Copy link

netlify bot commented Dec 3, 2019

Deploy preview for ant-design ready!

Built with commit 4164d70

https://deploy-preview-20053--ant-design.netlify.com

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 3, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4164d70:

Sandbox Source
antd reproduction template Configuration
strange-mcnulty-iwhhv Issue #20049

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #20053 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20053      +/-   ##
==========================================
+ Coverage   97.81%   97.81%   +<.01%     
==========================================
  Files         286      286              
  Lines        7734     7737       +3     
  Branches     2173     2173              
==========================================
+ Hits         7565     7568       +3     
  Misses        169      169
Impacted Files Coverage Δ
components/table/filterDropdown.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2cae43...4164d70. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip在Table的FilterIcon下不显示正确的title内容
1 participant