-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 Table filterIcon bugs #20053
fix: 🐛 Table filterIcon bugs #20053
Conversation
Deploy preview for ant-design ready! Built with commit 4164d70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4164d70:
|
Codecov Report
@@ Coverage Diff @@
## master #20053 +/- ##
==========================================
+ Coverage 97.81% 97.81% +<.01%
==========================================
Files 286 286
Lines 7734 7737 +3
Branches 2173 2173
==========================================
+ Hits 7565 7568 +3
Misses 169 169
Continue to review full report at Codecov.
|
🤔 This is a ...
🔗 Related issue link
close #20049
💡 Background and solution
📝 Changelog
filterIcon
throws error when render string or number.- Fix Table
filterIcon
show wrong title when returns Tooltip.filterIcon
返回字符串或数字时报错的问题。- 修复 Table
filterIcon
返回 Tooltip 时显示了错误的title
。☑️ Self Check before Merge
View rendered components/table/demo/custom-filter-panel.md