Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Input clear icon overclap with feedback icon #20017

Merged
merged 1 commit into from Nov 30, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 30, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #19884

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input clear icon overclap with feedback icon.
🇨🇳 Chinese 修复 Input 清除图标和反馈图标重合的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Nov 30, 2019

Deploy preview for ant-design ready!

Built with commit 803e443

https://deploy-preview-20017--ant-design.netlify.com

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 803e443:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #20017 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20017   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7706     7706           
  Branches     2155     2169   +14     
=======================================
  Hits         7537     7537           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e0587...803e443. Read the comment docs.

@afc163 afc163 changed the title fix: 🐛 Input clear icon overclap with feedback ico fix: 🐛 Input clear icon overclap with feedback icon Nov 30, 2019
@afc163 afc163 merged commit 329edc1 into master Nov 30, 2019
@afc163 afc163 deleted the fix-feedback-input branch November 30, 2019 09:34
@zombieJ zombieJ mentioned this pull request Dec 1, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Form.Item hasFeedback>'s feedback icon will cover <Input allowClear>'s clear icon
1 participant