Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TimePicker): fix time-picker disabled item focus style #19812

Merged
merged 1 commit into from Nov 22, 2019

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Nov 20, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

ref: #17447

馃挕 Background and solution

fix #19785

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English fix Time-picker disabled item focus style
馃嚚馃嚦 Chinese time-picker 绂佺敤椤硅仛鐒︽椂鏍峰紡淇

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Nov 20, 2019

Deploy preview for ant-design ready!

Built with commit 0505b15

https://deploy-preview-19812--ant-design.netlify.com

@yoyo837
Copy link
Contributor Author

yoyo837 commented Nov 20, 2019

workflows crash...

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 20, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0505b15:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #19812 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19812   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7705     7705           
  Branches     2120     2120           
=======================================
  Hits         7536     7536           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c57d7f3...0505b15. Read the comment docs.

@yoyo837 yoyo837 changed the title fix time-picker disabled item focus style fix(TimePicker): fix time-picker disabled item focus style Nov 20, 2019
@auto-add-label auto-add-label bot added the bug label Nov 20, 2019
@yoyo837 yoyo837 requested a review from afc163 November 20, 2019 02:48
@yoyo837 yoyo837 force-pushed the fix-time-picker-disabled-focus branch from 08fe73b to 0505b15 Compare November 21, 2019 02:29
@afc163 afc163 merged commit 040fe56 into master Nov 22, 2019
@afc163 afc163 deleted the fix-time-picker-disabled-focus branch November 22, 2019 07:47
@ycjcl868 ycjcl868 mentioned this pull request Nov 25, 2019
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled time should not clickable for TimePicker
2 participants