Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove react lifecycle warnings #19643

Merged
merged 2 commits into from Nov 9, 2019
Merged

fix: remove react lifecycle warnings #19643

merged 2 commits into from Nov 9, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 9, 2019 •
edited

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #9792

💡 Background and solution

Thx to react-component/form#355 and react-component/animate#82

图片

react-helmet => react-helmet-async.

edrlab/thorium-reader#596
nfl/react-helmet#465
nfl/react-helmet#426

📝 Changelog

Language Changelog
🇺🇸 English Finally, we fix all react lifecycle warnings.
🇨🇳 Chinese 清除了 React 生命周期警告信息。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered docs/react/recommendation.en-US.md
View rendered docs/react/recommendation.zh-CN.md

@auto-add-label auto-add-label bot added the chore label Nov 9, 2019
@netlify
Copy link

netlify bot commented Nov 9, 2019 •
edited

Deploy preview for ant-design ready!

Built with commit fe9d2e4

https://deploy-preview-19643--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Nov 9, 2019 •
edited

Codecov Report

Merging #19643 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19643   +/-   ##
=======================================
  Coverage    97.8%    97.8%           
=======================================
  Files         284      284           
  Lines        7704     7704           
  Branches     2168     2156   -12     
=======================================
  Hits         7535     7535           
  Misses        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9682fc...fe9d2e4. Read the comment docs.

@afc163
Copy link
Member Author

afc163 commented Nov 9, 2019 •
edited

There is no warnings now!!!

图片

@afc163 afc163 changed the title chore: fix SideEffect(NullComponent) warning fix: remove react lifecycle warnings Nov 9, 2019
@auto-add-label auto-add-label bot added bug and removed chore labels Nov 9, 2019
@buildsize
Copy link

buildsize bot commented Nov 9, 2019

File name Previous Size New Size Change
package-lock.json 904.89 KB 903.65 KB -1.23 KB (0%)

@afc163 afc163 mentioned this pull request Nov 9, 2019
Closed
54 tasks
@afc163 afc163 merged commit 0cf62f6 into master Nov 9, 2019
@afc163 afc163 deleted the use-react-helmet-async branch November 9, 2019 10:24
@weekly-digest weekly-digest bot mentioned this pull request Nov 10, 2019
Closed
@ycjcl868
Copy link
Contributor

bisheng 要改造下，服务端渲染出来 title 丢了

@ycjcl868 ycjcl868 mentioned this pull request Nov 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to new lifecycle methods
2 participants
@afc163 @ycjcl868