Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix result global Icon color #17404

Closed
wants to merge 1 commit into from
Closed

Conversation

clumsyme
Copy link

@clumsyme clumsyme commented Jul 2, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

The Result component style all Icons in it to the color baseed on status,that make some UI looks strange.

https://codepen.io/liyan/pen/QXmJZV?editors=0010

💡 Solution

The Icon color style should only apply to Icons in .ant-result-icon

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jul 2, 2019

Deploy preview for ant-design processing.

Building with commit ec59146

https://app.netlify.com/sites/ant-design/deploys/5d1ae34b40e33a000779c167

@afc163
Copy link
Member

afc163 commented Jul 2, 2019

@chenshuai2144

@chenshuai2144
Copy link
Contributor

chenshuai2144 commented Jul 2, 2019

抱歉, 这个 pr 已经改动了。

#17389

@clumsyme
Copy link
Author

clumsyme commented Jul 2, 2019

抱歉, 这个 pr 已经改动了。

#17389

👌

@clumsyme clumsyme closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants