Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong height of TextArea & DatePicker #17165

Merged
merged 1 commit into from Jun 19, 2019
Merged

fix: Wrong height of TextArea & DatePicker #17165

merged 1 commit into from Jun 19, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 19, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

fix #17163
fix #17143
fix #17159

💡 Solution

Reset line-height back

📝 Changelog

Language Changelog
🇺🇸 English Fix wrong height of TextArea & DatePicker
🇨🇳 Chinese 修复 TextArea 和 DatePicker 的高度问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jun 19, 2019

Deploy preview for ant-design ready!

Built with commit d9b4b7d

https://deploy-preview-17165--ant-design.netlify.com

@zombieJ zombieJ requested a review from afc163 June 19, 2019 03:06
@afc163
Copy link
Member

afc163 commented Jun 19, 2019

close #17159

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #17165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17165   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         263      263           
  Lines        7348     7348           
  Branches     2051     2053    +2     
=======================================
  Hits         7051     7051           
  Misses        295      295           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a676f37...d9b4b7d. Read the comment docs.

@zombieJ zombieJ merged commit dc4102d into master Jun 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-line-height branch June 19, 2019 03:23
@zombieJ zombieJ mentioned this pull request Jun 19, 2019
10 tasks
@msingleton
Copy link

Thanks for the quick fix @zombieJ !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants