fix: prop headerRender should be optional for component Calendar #17063
Conversation
|
Deploy preview for ant-design ready! Built with commit 180ed01 |
Codecov Report
@@ Coverage Diff @@
## master #17063 +/- ##
==========================================
- Coverage 96% 95.96% -0.05%
==========================================
Files 263 263
Lines 7340 7340
Branches 2009 2050 +41
==========================================
- Hits 7047 7044 -3
- Misses 291 294 +3
Partials 2 2
Continue to review full report at Codecov.
|
| @@ -178,8 +180,8 @@ export default class Header extends React.Component<HeaderProps, any> { | |||
| ); | |||
| }; | |||
|
|
|||
| headerRenderCustom = (): React.ReactNode => { | |||
| const { headerRender, type, onValueChange, value } = this.props; | |||
There was a problem hiding this comment.
I think this change is unnecessary.
There was a problem hiding this comment.
I change here because
const { headerRender, type, onValueChange, value } = this.props;
Type of headerRender is HeaderRender | undefined
If I pass headerRender as function argument, because the func is called by
headerRender ? this.headerRenderCustom(headerRender) : (...)
the type of headerRender is HeaderRender
I just want to avoid the repeated undefined check in TS
馃 This is a ...
馃懟 What's the background?
In Release 13.19.0, new prop headerRender is added for component Calendar(#16535 ), but the ts definition define it mandatory. It's designed as optional in fact.
馃挕 Solution
馃摑 Changelog
鈽戯笍 Self Check before Merge