-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Breadcrumb): when route.children exist, the path of children is wrong #16885
Conversation
<Menu.Item key={child.breadcrumbName || child.path}> {itemRender(child, params, routes, [...paths, this.getPath(child.path, params)])} </Menu.Item> itemRender(...args) 中路径应该到拼接当前child.path
getPath() 参数赋默认值
Any reproduce. |
在这种情形下渲染的
路径应该是'#/first/general' |
对于子路径是否为空进行判断
Codecov Report
@@ Coverage Diff @@
## master #16885 +/- ##
==========================================
+ Coverage 95.96% 96% +0.04%
==========================================
Files 263 263
Lines 7329 7337 +8
Branches 2048 2050 +2
==========================================
+ Hits 7033 7044 +11
+ Misses 294 291 -3
Partials 2 2
Continue to review full report at Codecov.
|
Could you create a codesandbox: http://u.ant.design/codesandbox-repro |
ci broken. |
https://codesandbox.io/embed/antd-reproduction-template-m3qsw |
https://codesandbox.io/embed/antd-reproduction-template-m3qsw
当我点击first-Layout 时 浏览器地址没有显示到#/index/first/layout,而是还是停留在#/index/first
------------------ 原始邮件 ------------------
发件人: "偏右"<notifications@github.com>;
发送时间: 2019年5月30日(星期四) 晚上11:53
收件人: "ant-design/ant-design"<ant-design@noreply.github.com>;
抄送: "海岸微风"<1531297152@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [ant-design/ant-design] Fix breadcrumb (#16885)
Could you create a codesandbox: http://u.ant.design/codesandbox-repro
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
🤔 This is a ...
👻 What's the background?
💡 Solution
📝 Changelog
☑️ Self Check before Merge