Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace react-sticky to react-sticky-box in Tabs demo #39898

Merged
merged 2 commits into from Dec 29, 2022

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 29, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #24775

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English --
🇨🇳 Chinese --

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022

size-limit report 📦

Path Size
./dist/antd.min.js 367.29 KB
./dist/antd-with-locales.min.js 422.41 KB

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (efe0d56) compared to base (fbeddb5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39898   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          559       559           
  Lines         9555      9565   +10     
  Branches      2710      2713    +3     
=========================================
+ Hits          9555      9565   +10     
Impacted Files Coverage Δ
components/modal/useModal/HookModal.tsx 100.00% <0.00%> (ø)
components/table/hooks/useFilter/index.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member Author

afc163 commented Dec 29, 2022

来个 +1

@afc163 afc163 merged commit cf41f81 into master Dec 29, 2022
@afc163 afc163 deleted the chore/tabs-sticky-demo branch December 29, 2022 10:37
@afc163 afc163 mentioned this pull request Dec 29, 2022
13 tasks
yoyo837 pushed a commit that referenced this pull request Dec 31, 2022
* docs: replace react-sticky to react-sticky-box in Tabs demo

* test: fix test case
@afc163 afc163 mentioned this pull request Mar 14, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change react-sticky dependency (contains deprecated code)
2 participants