Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove useless tsx support #39890

Merged
merged 11 commits into from Dec 29, 2022
Merged

chore: remove useless tsx support #39890

merged 11 commits into from Dec 29, 2022

Conversation

li-jia-nan
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English chore: remove useless tsx support
🇨🇳 Chinese chore: 移除无用的 tsx 支持

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022 •
edited

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022 •
edited

size-limit report 📦

Path Size
./dist/antd.min.js 367.27 KB (-17 B 🔽)
./dist/antd-with-locales.min.js 422.39 KB (-23 B 🔽)

@li-jia-nan
Copy link
Member Author

改动有点多，提交了一部分，后面再开一个pr

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 29, 2022

改动有点多，提交了一部分，后面再开一个pr

没颜色的不用看 /忍者

@codecov
Copy link

codecov bot commented Dec 29, 2022 •
edited

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (8c1a8e5) compared to base (fbeddb5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##            master    #39890    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          559       591    +32     
  Lines         9555     10071   +516     
  Branches      2710      2722    +12     
==========================================
+ Hits          9555     10071   +516
Impacted Files Coverage Δ
components/_util/getScroll.ts 100.00% <ø> (ø)
components/_util/motion.ts 100.00% <ø> (ø)
components/_util/placements.ts 100.00% <ø> (ø)
components/_util/statusUtils.ts 100.00% <ø> (ø)
components/_util/styleChecker.ts 100.00% <ø> (ø)
components/_util/throttleByAnimationFrame.ts 100.00% <ø> (ø)
components/_util/transKeys.ts 100.00% <ø> (ø)
components/affix/style/index.ts 100.00% <ø> (ø)
components/alert/style/index.ts 100.00% <ø> (ø)
components/anchor/index.ts 100.00% <ø> (ø)
... and 222 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jia-nan
Copy link
Member Author

改动有点多，提交了一部分，后面再开一个pr

没颜色的不用看 /忍者

github 上面没啥问题，改太多我的 vscode diff 会抽风……

@afc163
Copy link
Member

afc163 commented Dec 29, 2022

antd-with-locales.min.js 文件小这么多，不太合理

@li-jia-nan
Copy link
Member Author

antd-with-locales.min.js 文件小这么多，不太合理

确实不合理……我看一下，是不是把什么不小心删了……

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 29, 2022

antd-with-locales.min.js 文件小这么多，不太合理

有看出来哪里不对吗?
会不会之前的才是不对的? 😂

@li-jia-nan
Copy link
Member Author

antd-with-locales.min.js 文件小这么多，不太合理

有看出来哪里不对吗? 会不会之前的才是不对的? 😂

按理来说只改了文件后缀，应该不会影响打包产物的吧……

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 29, 2022

好刺激, 白得60K 😄

@MadCcc
Copy link
Member

MadCcc commented Dec 29, 2022 •
edited

image

要改 entry，这个 60k 是 locale 丢了

MadCcc
MadCcc reviewed Dec 29, 2022
View reviewed changes
index-with-locales.js Outdated Show resolved Hide resolved
afc163
afc163 reviewed Dec 29, 2022
View reviewed changes
index-with-locales.js Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Dec 29, 2022

antd.min.js 为啥会变小？

@li-jia-nan
Copy link
Member Author

antd.min.js 为啥会变小？

path 简化了，少了几个变量

@MadCcc
Copy link
Member

MadCcc commented Dec 29, 2022

能不能把产物 diff 打出来看的。。

@li-jia-nan
Copy link
Member Author

能不能把产物 diff 打出来看的。。

我在本地跑一下 npm run build 看看

@afc163
Copy link
Member

afc163 commented Dec 29, 2022

现在的数据合理多了。

@li-jia-nan
Copy link
Member Author

能不能把产物 diff 打出来看的。。

我在本地跑一下 npm run build 看看

本地打包看了一下diff，结果文件太长，编辑器直接卡住了…… 不过这次看 CI 数据是比较合理的

@afc163 afc163 merged commit 9aec72c into master Dec 29, 2022
@afc163 afc163 deleted the uselessTsx branch December 29, 2022 10:33
yoyo837 pushed a commit that referenced this pull request Dec 31, 2022
@li-jia-nan @yoyo837
chore: remove useless tsx support (#39890)
3ed7ec9 
* chore: remove useless tsx support

* add

* add

* style

* fix lint

* fix lint

* fix lint

* update locale entry

* update locale entry

* update locale entry

* delete useless style
@li-jia-nan li-jia-nan mentioned this pull request Dec 31, 2022
Closed
@PeachScript PeachScript mentioned this pull request Jan 3, 2023
Merged
20 tasks
@MadCcc MadCcc mentioned this pull request Jan 4, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@MadCcc MadCcc MadCcc left review comments

@yoyo837 yoyo837 yoyo837 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@li-jia-nan @yoyo837 @afc163 @MadCcc