fix(Drawer): default props not working #39782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
afc163
commented
Dec 24, 2022
scripts/post-script.js
Outdated
| @@ -25,6 +25,7 @@ const DEPRECIATED_VERSION = { | |||
| '4.24.0': ['https://github.com/ant-design/ant-design/issues/38371'], | |||
| '5.0.4': ['https://github.com/ant-design/ant-design/issues/39284'], | |||
| '5.0.6': [], | |||
There was a problem hiding this comment.
我记得是没有 issue 相关，应该是 rc-tour 错版的问题，打个注释吧
size-limit report 📦
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #39782 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 557 557
Lines 9625 9625
Branches 2722 2722
=========================================
Hits 9625 9625 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
li-jia-nan
approved these changes
Dec 25, 2022
MadCcc
reviewed
Dec 26, 2022
scripts/post-script.js
Outdated
| @@ -25,6 +25,7 @@ const DEPRECIATED_VERSION = { | |||
| '4.24.0': ['https://github.com/ant-design/ant-design/issues/38371'], | |||
| '5.0.4': ['https://github.com/ant-design/ant-design/issues/39284'], | |||
| '5.0.6': [], | |||
There was a problem hiding this comment.
我记得是没有 issue 相关，应该是 rc-tour 错版的问题，打个注释吧
|
间隙性异常。 |
afc163
commented
Dec 26, 2022
scripts/post-script.js
Outdated
| @@ -24,7 +24,8 @@ const DEPRECIATED_VERSION = { | |||
| ], | |||
| '4.24.0': ['https://github.com/ant-design/ant-design/issues/38371'], | |||
| '5.0.4': ['https://github.com/ant-design/ant-design/issues/39284'], | |||
| '5.0.6': [], | |||
| '5.0.6': [], // Issue with @rc-components/tour v1.0.3 | |||
MadCcc
reviewed
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #39711
close #39777
💡 Background and solution
具体改动见：react-component/drawer#370
<Drawer open={undefined} placement={undefined} />会覆盖 default props，不等效于<Drawer />。虽然 semver 会自动更新，但 dist 文件还是有问题，semver 也有可能安装到 6.1.0。这里强制升级上来。
📝 Changelog
placementopenwidthareundefined.placementopenwidth等参数为 undefined 时默认值不生效的问题。☑️ Self-Check before Merge