Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ConfigProvider): add icons config #6587

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Conversation

guoyunhe
Copy link
Contributor

@guoyunhe guoyunhe commented Apr 3, 2024

增加一种通过 <ConfigProvider> 设置全局图标替换的方式:

import { SuccessFill, ErrorFill, Loading } from 'my-icon-pack'

<ConfigProvider icons={{
  ToastSuccess: SuccessFill,
  ToastFail: ErrorFill,
  ToastLoading: Loading,
}}>
  <App/>
</ConfigProvider>

Copy link
Contributor

github-actions bot commented Apr 3, 2024

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6587.surge.sh

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (cf550e4) to head (a10882d).
Report is 8 commits behind head on master.

❗ Current head a10882d differs from pull request most recent head 13a899d. Consider uploading reports for the commit 13a899d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6587      +/-   ##
==========================================
+ Coverage   92.34%   92.52%   +0.17%     
==========================================
  Files         318      319       +1     
  Lines        6910     6969      +59     
  Branches     1729     1760      +31     
==========================================
+ Hits         6381     6448      +67     
+ Misses        493      485       -8     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
./lib/bundle/antd-mobile.es.js 137.36 KB (+347 B 🔺) 2.8 s (+0.25% 🔺) 1.2 s (+2.06% 🔺) 4 s

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Size Change: +1.26 kB (0%)

Total Size: 353 kB

Filename Size Change
./lib/bundle/antd-mobile.compatible.umd.js 190 kB +791 B (0%)
./lib/bundle/antd-mobile.umd.js 144 kB +492 B (0%)
./lib/bundle/style.css 17.9 kB -18 B (0%)
ℹ️ View Unchanged
Filename Size
./lib/bundle/css-vars-patch.css 1.43 kB

compressed-size-action

@guoyunhe guoyunhe force-pushed the config-provider-icons branch 4 times, most recently from 0e24aca to a10882d Compare April 4, 2024 06:01
@guoyunhe guoyunhe requested a review from zombieJ April 4, 2024 06:34
@guoyunhe guoyunhe force-pushed the config-provider-icons branch 8 times, most recently from 2e3a0c1 to ab0d47b Compare April 8, 2024 12:38
@guoyunhe guoyunhe force-pushed the config-provider-icons branch 3 times, most recently from 219bde4 to 9f3cd52 Compare April 11, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants