test: fix failed tests

ant-design · Apr 14, 2022 · 5918a41 · 5918a41
1 parent f167cfb
commit 5918a41
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 24 deletions.
diff --git a/src/components/action-sheet/tests/__snapshots__/action-sheet.test.tsx.snap b/src/components/action-sheet/tests/__snapshots__/action-sheet.test.tsx.snap
@@ -2,7 +2,7 @@
 
 exports[`ActionSheet basic usage 1`] = `
 <body
-  class="adm-overflow-hidden"
+  class=""
 >
   <div>
     <button

diff --git a/src/components/action-sheet/tests/action-sheet.test.tsx b/src/components/action-sheet/tests/action-sheet.test.tsx
@@ -154,11 +154,12 @@ describe('ActionSheet', () => {
     )
     fireEvent.click(getByText('button'))
 
-    await waitFor(() =>
+    await waitFor(() => {
       fireEvent.click(baseElement.querySelectorAll(`.adm-mask-aria-button`)[0])
-    )
-    await sleep(1000)
-    expect(baseElement.querySelectorAll(`.${classPrefix}`)[0]).toBeVisible()
+    })
+    await waitFor(() => {
+      expect(baseElement.querySelectorAll(`.${classPrefix}`)[0]).toBeVisible()
+    })
   })
 
   test('action click shound be called', async () => {

diff --git a/src/components/form/tests/form.test.tsx b/src/components/form/tests/form.test.tsx
@@ -46,23 +46,23 @@ describe('Form', () => {
 
     console.error = jest.fn()
 
+    fireEvent.click(getByText('submit'))
     await waitFor(() => {
-      fireEvent.click(getByText('submit'))
+      expect($$(`.${classPrefix}-item-feedback-error`).length).toBeTruthy()
     })
 
-    expect($$(`.${classPrefix}-item-feedback-error`).length).toBeTruthy()
     expect(console.error).toBeCalledTimes(0)
 
     fireEvent.change(getByLabelText(/name/i), { target: { value: 'name' } })
     fireEvent.change(getByLabelText(/address/i), {
       target: { value: 'address' },
     })
 
+    fireEvent.click(getByText('submit'))
+    expect(console.error).toBeCalledTimes(0)
     await waitFor(() => {
-      fireEvent.click(getByText('submit'))
+      expect(fn.mock.calls[0][0]).toEqual({ name: 'name', address: 'address' })
     })
-    expect(console.error).toBeCalledTimes(0)
-    expect(fn.mock.calls[0][0]).toEqual({ name: 'name', address: 'address' })
   })
 
   test('renders with horizontal layout', async () => {
@@ -151,11 +151,11 @@ describe('Form', () => {
       </Form>
     )
 
+    fireEvent.submit(getByTestId('form'))
+
     await waitFor(() => {
-      fireEvent.submit(getByTestId('form'))
+      expect(getByTestId('form')).toHaveTextContent(`'test' is required`)
     })
-
-    expect(getByTestId('form')).toHaveTextContent(`'test' is required`)
   })
 
   test("`shouldUpdate` shouldn't work with render porps", async () => {

diff --git a/src/components/stepper/tests/stepper.test.tsx b/src/components/stepper/tests/stepper.test.tsx
@@ -3,7 +3,7 @@ import React, { useEffect, useState } from 'react'
 import { Stepper } from '../stepper'
 
 describe('stepper', () => {
-  test('control works', () => {
+  test('control works', async () => {
     const onChange = jest.fn()
 
     const Element = () => {
@@ -24,12 +24,12 @@ describe('stepper', () => {
     const { container } = render(<Element></Element>)
 
     // plus
-    container.getElementsByTagName('button')[1].click()
+    await waitFor(() => container.getElementsByTagName('button')[1].click())
     expect(onChange).toHaveBeenLastCalledWith(2)
 
     // plus
     container.getElementsByTagName('button')[1].click()
-    expect(container.getElementsByTagName('input')[0].value).toBe('2')
+    expect(onChange).toBeCalledTimes(1)
 
     const input = container.getElementsByTagName('input')[0]
 
@@ -68,18 +68,18 @@ describe('stepper', () => {
     })
   })
 
-  test('step works', () => {
+  test('step works', async () => {
     const onChange = jest.fn()
     const { container } = render(
       <Stepper defaultValue={0} step={100} onChange={onChange} />
     )
     // minus
-    container.getElementsByTagName('button')[0].click()
-    expect(onChange).toHaveBeenLastCalledWith(-100)
+    await waitFor(() => container.getElementsByTagName('button')[0].click())
+    expect(onChange.mock.calls[0][0]).toBe(-100)
 
     // plus
-    container.getElementsByTagName('button')[1].click()
-    expect(onChange).toHaveBeenLastCalledWith(0)
+    await waitFor(() => container.getElementsByTagName('button')[1].click())
+    expect(onChange.mock.calls[1][0]).toBe(0)
   })
 
   test('digits works', () => {
@@ -103,14 +103,13 @@ describe('stepper', () => {
 
     // max
     for (let i = 1; i <= 11; i++) {
-      container.getElementsByTagName('button')[1].click()
-
+      await waitFor(() => container.getElementsByTagName('button')[1].click())
       expect((onChange.mock as any).lastCall[0]).toBeLessThanOrEqual(0.2)
     }
 
     // min
     for (let i = 20; i >= -1; i--) {
-      container.getElementsByTagName('button')[0].click()
+      await waitFor(() => container.getElementsByTagName('button')[0].click())
       expect((onChange.mock as any).lastCall[0]).toBeGreaterThanOrEqual(0)
     }