Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tags to documentation #1282

Merged
merged 8 commits into from Jul 25, 2022
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 22, 2022

Adding tag to documentation commits in documentation deployment repos.

Close #1171

@germa89 germa89 added Enhancement Improve any current implemented feature Documentation Documentation related (improving, adding, etc) CI/CD Related with CICD, Github Actions, etc labels Jul 22, 2022
@germa89 germa89 self-assigned this Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1282 (f7f2ad8) into main (39402d2) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1282      +/-   ##
==========================================
+ Coverage   75.86%   75.92%   +0.06%     
==========================================
  Files          43       43              
  Lines        6765     6780      +15     
==========================================
+ Hits         5132     5148      +16     
+ Misses       1633     1632       -1     

@akaszynski
Copy link
Collaborator

This ready for review?

@germa89
Copy link
Collaborator Author

germa89 commented Jul 24, 2022

I'm testing the changes on the nightly build. It did failed on Friday because it didn't find the updated one? Hopefully now it is ok.

…I'm not taking the blame on this one. No way.
@germa89
Copy link
Collaborator Author

germa89 commented Jul 24, 2022

It works in the nightly build:

https://github.com/pyansys/pymapdl-dev-docs/tags

https://github.com/pyansys/pymapdl/runs/7490499058?check_suite_focus=true

Hence applying to main. I'm not going to fully test it until next release though.

@germa89
Copy link
Collaborator Author

germa89 commented Jul 24, 2022

This should be ready if all the checks are green.

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@akaszynski akaszynski merged commit 115796e into main Jul 25, 2022
@akaszynski akaszynski deleted the feat/adding-tags-to-documentation branch July 25, 2022 03:39
@akaszynski akaszynski restored the feat/adding-tags-to-documentation branch August 3, 2022 05:51
akaszynski added a commit that referenced this pull request Aug 3, 2022
akaszynski added a commit that referenced this pull request Aug 3, 2022
* Revert "Adding tags to documentation (#1282)"

This reverts commit 115796e.

* Apply suggestions from code review
@germa89 germa89 mentioned this pull request Aug 5, 2022
2 tasks
germa89 added a commit that referenced this pull request Sep 1, 2022
@germa89 germa89 deleted the feat/adding-tags-to-documentation branch December 29, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tag version to PyMAPDL documentation
2 participants