Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Bump actions/download-artifact from 3 to 4 #4096

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 17, 2024

Bumps actions/download-artifact from 3 to 4.

Release notes

Sourced from actions/download-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

ℹ️ However, this is a major update that includes breaking changes. Artifacts created with versions v3 and below are not compatible with the v4 actions. Uploads and downloads must use the same major actions versions. There are also key differences from previous versions that may require updates to your workflows.

For more information, please see:

  1. The changelog post.
  2. The README.
  3. The migration documentation.
  4. As well as the underlying npm package, @​actions/artifact documentation.

New Contributors

Full Changelog: actions/download-artifact@v3...v4.0.0

v3.0.2

v3.0.1

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Jan 17, 2024
@dependabot dependabot bot requested a review from MaxJPRey January 17, 2024 21:27
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd047a7) 82.10% compared to head (364e494) 31.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4096       +/-   ##
===========================================
- Coverage   82.10%   31.00%   -51.10%     
===========================================
  Files         183      183               
  Lines       64464    64464               
===========================================
- Hits        52926    19987    -32939     
- Misses      11538    44477    +32939     

@Samuelopez-ansys
Copy link
Member

@MaxJPRey @SMoraisAnsys Not sure if we should update, please check if this could introduce any issue

@SMoraisAnsys
Copy link
Collaborator

SMoraisAnsys commented Jan 18, 2024

@Samuelopez-ansys we should avoid to accept this PR for the moment as we had to revert from v4 to v3 too avoid an issue with the number of file we are uploading (cf actions/upload-artifact#485)

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked until documentation build is fixed

@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/download-artifact-4 branch from cae6ea1 to 58fcc75 Compare January 26, 2024 08:22
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/download-artifact-4 branch from 58fcc75 to 801bf00 Compare February 1, 2024 08:47
@Samuelopez-ansys
Copy link
Member

@SMoraisAnsys @MaxJPRey @maxcapodi78

What should we do with these Pull requests?

Not sure if it is going to work, we have to check these 3 updates:

ansys/actions/doc-deploy-stable@v5
actions/upload-artifact@v4
actions/download-artifact@v4

@SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys @MaxJPRey @maxcapodi78

What should we do with these Pull requests?

Not sure if it is going to work, we have to check these 3 updates:

ansys/actions/doc-deploy-stable@v5 actions/upload-artifact@v4 actions/download-artifact@v4

If it bother you, we can close it but I would prefer to leave the 3 PR open as a reminder.
For the moment, we cannot move forward as actions/upload-artifact#485 is still open. More and more people are reverting to the previous version as we did. Hopefuly that will have an impact. Please, consider putting a 👍 on this issue to increase its weight :)

If no fix is proposed soon, I'll try to find some time and look for a bugfix to propose.

@MaxJPRey
Copy link
Collaborator

MaxJPRey commented Feb 6, 2024

@SMoraisAnsys @MaxJPRey @maxcapodi78
What should we do with these Pull requests?
Not sure if it is going to work, we have to check these 3 updates:
ansys/actions/doc-deploy-stable@v5 actions/upload-artifact@v4 actions/download-artifact@v4

If it bother you, we can close it but I would prefer to leave the 3 PR open as a reminder. For the moment, we cannot move forward as actions/upload-artifact#485 is still open. More and more people are reverting to the previous version as we did. Hopefuly that will have an impact. Please, consider putting a 👍 on this issue to increase its weight :)

If no fix is proposed soon, I'll try to find some time and look for a bugfix to propose.

@SMoraisAnsys I fully agree with you.

@Samuelopez-ansys
Copy link
Member

@SMoraisAnsys What should we do with this PR?

@SMoraisAnsys
Copy link
Collaborator

SMoraisAnsys commented Apr 22, 2024

@Samuelopez-ansys I'm on days off but I'll see if we can do the associated changes if the CI refactoring.
Part of it seems to be possible when runnings without examples on linux.
However, we can't do that for the one with examples on windows as the issue is still opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants