Add unit tests for content creator utility functions #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyamsahoo
force-pushed
the
add-unit-tests
branch
from
e38faec
to
91f6b8d
Compare
audgirka
approved these changes
May 23, 2024
goneri
reviewed
May 23, 2024
| @@ -956,7 +956,7 @@ | |||
| "package": "./tools/package.sh", | |||
| "preinstall": "", | |||
| "pretest": "yarn run compile", | |||
| "unit-tests": "nyc mocha --recursive test/units", | |||
| "unit-tests": "nyc mocha --recursive test/units/lightspeed", | |||
There was a problem hiding this comment.
How do you trigger these new tests?
There was a problem hiding this comment.
These tests are triggered using the test-e2e script.
These new tests depend on the vscode engine, and thus, it is not possible to trigger them using mocha.
There was a problem hiding this comment.
This is actually the reason why we created the tests/units directory originally. The idea was that unit-tests should not import vscode at all and just depend on a regular Javascript environment. If your tests are depending on the vscode run-time, maybe you can move your tests in a different directory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR will add unit tests for the utility functions written for the content creator features in the extension.