Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request GITHUB_TOKEN for push workflow #36

Merged
merged 1 commit into from Mar 1, 2022
Merged

Request GITHUB_TOKEN for push workflow #36

merged 1 commit into from Mar 1, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 1, 2022

This should help use avoid release-drafter/release-drafter#1081

@ssbarnea ssbarnea added the bug Something isn't working label Mar 1, 2022
@ssbarnea ssbarnea requested a review from webknjaz March 1, 2022 16:11
@ssbarnea
Copy link
Member Author

ssbarnea commented Mar 1, 2022

Update: as it seems that only some workflows are affected by the linked issue, I wonder if we should just make the secret optional.

I am still surprised it works for some cases and not for others.

@ssbarnea ssbarnea merged commit 1095f70 into ansible:main Mar 1, 2022
@ssbarnea ssbarnea deleted the fix/push-token branch March 1, 2022 18:13
ssbarnea added a commit that referenced this pull request Mar 2, 2022
Github does not allow use of the reserved name, giving error parsing called workflow "ansible-community/devtools/.github/workflows/push.yml@main": secret name `GITHUB_TOKEN` within `workflow_call` can not be used since it would collide with system reserved name
ssbarnea added a commit that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants