Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump react scripts to 5.0 #11568

Merged
merged 1 commit into from Feb 9, 2022
Merged

Bump react scripts to 5.0 #11568

merged 1 commit into from Feb 9, 2022

Conversation

nixocio
Copy link
Contributor

@nixocio nixocio commented Jan 19, 2022 •
edited

Bump react scripts to 5.0

I was not able to run those commands inside the container to ensure version, but I verified my dev env, and I used the following versions:

after
npm ci

I ran

npm install --save-dev --save-exact react-scripts@5.0.0


(base) ➜  ui git:(ui_rs5) node -v
v14.18.3
(base) ➜  ui git:(ui_rs5) npm -v
7.24.2

See: #11543

@nixocio nixocio force-pushed the ui_rs5 branch 17 times, most recently from f732c32 to e9ee4eb Compare January 27, 2022 21:30
@cypress
Copy link

cypress bot commented Jan 28, 2022 •
edited


Test summary

491 • 26 • 1429 • 160 • Flakiness 4

Run details
Project AWX - Functional
Status Failed
Commit a21582e
Started Feb 2, 2022 7:27 PM
Ended Feb 2, 2022 9:45 PM
Duration 17:45 💡
OS Linux Debian - 10.11
Browser Chrome 96

View run in Cypress Dashboard ➡️

Failures

dashboard/dashboard.spec.js 3 Failed
1 Recent Job Runs > Can view Recent Jobs
2 Recent Job Runs- Sort and Filter > Can Perform Sort by Name for a Recent Job
3 Recently Used Templates > Can view Recent Templates
hosts/hosts-tabs.spec.js 2 Failed
1 Host Resource- Facts tab > user can view all facts
2 Host Resource- Completed jobs tab > can perform a basic search of jobs associated with the host
jobs/job-list.spec.js 5 Failed
1 Jobs List > can expand and collapse a row
2 Jobs List- Failed > Can view a job which ultimately ends in Failure
3 Sort operations > can sort by name after performing advanced search
4 Search operations - Jobs > can perform basic search for Jobs by Name
5 Filter Operations- Jobs > can can clear all filters
This comment includes only the first 10 test failures. See all 26 failures in the Cypress Dashboard.

Flakiness

inventories/inventories-list.spec.js 1 Flakiness
1 Inventory list- Search > Allows the user to search by Organization
pagination.spec.js 1 Flakiness
1 list pagination > Toggle visible items on page > Can toggle the amount of visible items in the credential list
user-journeys/jt-admin-journey.spec.js 1 Flakiness
1 Admin Rights- JT Add options RBAC > JT admin cannot see the dropdown option to add a WF
user-journeys/wf-admin-journey.spec.js 1 Flakiness
1 Template Add options RBAC > Workflow admin cannot see the dropdown option to add a JT

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@nixocio nixocio force-pushed the ui_rs5 branch 7 times, most recently from 35484b7 to 8c41a4b Compare January 31, 2022 15:12
@nixocio nixocio changed the title WIP - Bump react scripts to 5.0 Bump react scripts to 5.0 Jan 31, 2022
@tiagodread
Copy link
Contributor

@nixocio all the brokent tests is related to notification templates, they might be the same issue

@nixocio
Copy link
Contributor Author

nixocio commented Jan 31, 2022

@tiagodread

@nixocio all the brokent tests is related to notification templates, they might be the same issue

There is a newer run after I pushed some changes. The newer results did not update the link above.

cypress

AlexSCorey
AlexSCorey approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nixocio and I spoke offline and agree that many of the eslint-disable... comments can probably be addressed pretty easily but a separate issue will be filed to address them at a later date.

@nixocio nixocio force-pushed the ui_rs5 branch 2 times, most recently from a21582e to a60083d Compare February 4, 2022 13:27
@nixocio
Copy link
Contributor Author

nixocio commented Feb 4, 2022

This PR is affected by patternfly/patternfly-react#5650, but the work around in place is not solving the problem.

@nixocio nixocio force-pushed the ui_rs5 branch 3 times, most recently from fb14fe7 to 32c1e2f Compare February 8, 2022 15:41
@nixocio
Bump react scripts to 5.0
9703fb0 
Bump react scripts to 5.0

See: ansible#11543

Bump eslint

Bump eslint and related plugins

Add @babe/core

Add @babe/core remove babel/core.

Rename .eslintrc to .eslintrc.json

Rename .eslintrc to .eslintrc.json

Add extra plugin

Move babe-plugin-macro as dev dependencies

Move babe-plugin-macro as dev dependencies

Add preset-react

Add preset-react

Fixing lint errors

Fixing lint errors

Run eslint --fix

Run eslint --fix

Turn no-restricted-exports off

Turn no-restricted-exports off

Revert "Run eslint --fix"

This reverts commit e760885.

Run --fix

Run --fix

Fix lint errors

Also bump specificity of Select CSS border component to avoid bug of
missing borders.

Also update API tests related to lincenses.
@nixocio
Copy link
Contributor Author

nixocio commented Feb 8, 2022 •
edited

@tiagodread, I fixed the discrepancy from dev/production builds and started a new run for e2e tests. Ready to be reviewed again.

@tiagodread tiagodread self-assigned this Feb 8, 2022
@tiagodread
Copy link
Contributor

Assigning myself since I'm pairing along with @nixocio on this one

tiagodread
tiagodread approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@tiagodread tiagodread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all e2e tests are green and all screenshots hasn't any large isse, we can go ahead and merge this one

@nixocio nixocio merged commit afc0732 into ansible:devel Feb 9, 2022
@nixocio nixocio mentioned this pull request Feb 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagodread tiagodread tiagodread approved these changes

@AlexSCorey AlexSCorey AlexSCorey approved these changes

Assignees

@tiagodread tiagodread

Labels
component:api component:docs component:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nixocio @tiagodread @AlexSCorey