New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass new ansible-runner parameters to reduce number of artifacts we don't need on file system #11472
Conversation
Now I'm testing in conjunction with ansible/ansible-runner#943 |
That's working as intended. I'll mark this as non-draft whenever the ansible-runner PR merges. |
1710c91
to
4c7f831
Compare
I rebuilt the image and ran the demo job template with cleanup turned off, it produces this:
This is a pretty good reflection of the intent. The structures match, not as much unnecessary stuff being written. |
4c7f831
to
a875470
Compare
There's still a problem here, because we get things from the artifact directory after a run has completed. With this work, that has obviously moved. This affects inventory, facts, and other stuff. |
that should be wrapped up with the last commit, kicking off more tests now. |
7a3dc15
to
ed2018d
Compare
This requires corresponding ansible-runner changes which are only available in devel branch to do this, requirements are changed to install ansible-runner devel as it did before Revert "Use ansible-runner 2.1.1 build" This reverts commit f0ede01. Add back in change from updater.sh that we want to keep
ed2018d
to
2609ee5
Compare
I discovered an unexpected test failure related to this. This is where my latest commit is coming from - it deletes the artifacts folder after it has been sent so that we can detect cases where the fact cache was cleared. Looking further at this, I went down the rabbit hole which was #11560, and I have a pretty good idea of some followup bug fixes and improvements. I also believe that AWX I believe this PR should work as good as current |
SUMMARY
Connect #11356
Direct follow-up from ansible/ansible-runner#937 and ansible/ansible-runner#939
This has not been tested. At all. Once I verify functionality I will make it non-draft.
ISSUE TYPE
COMPONENT NAME