Upgrade d3 to v7. #11282
Upgrade d3 to v7. #11282
Conversation
| @@ -101,6 +101,9 @@ | |||
| "coveragePathIgnorePatterns": [ | |||
| "<rootDir>/src/locales", | |||
| "index.js" | |||
| ], | |||
| "transformIgnorePatterns": [ | |||
| "<rootDir>/node_modules/(?!d3)/" | |||
There was a problem hiding this comment.
It wasn't easy to track this down, however following a trail of release logs eventually led me to the solution on how to get jest to work again.
In short, d3 v7 introduces a new version of their sub packages (d3-array, d3-hierarchy, etc). v3 of these packages have adopted a new module type. These packages are now ESM modules instead of CommonJS. Jest ships with experimental support of ESM modules, and in order for the tests to properly import the packages when the tests are ran is to disable code transformation from within the d3 directory.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
|
Good job @kialam, the e2e test failures are also present on devel. Not related to this change. |
|
See: #10594 |
SUMMARY
Upgrade D3 to v7.
COMPONENT NAME