PlayIterator, refactored #83134
Open
PlayIterator, refactored #83134
+158
−335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this simplifies things a lot, before the complete state there is still posibility that the failure would be recovered, or the host is failed but the always section needs to be iterated
now that we only have one child_state
... in case of a failure outside of PlayIterator
easier to preserve order
...operate on the state itself, not the copy, which is almost always what we want, especially for read-only operations
... as printing the whole struture could be very inefficient since the states are always str'ed for display.debug
ansibot
added
feature
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
removed
the
needs_ci
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
added
the
needs_revision
webknjaz
added
the
ci_verified
ansibot
removed
needs_revision
mattclay
removed
the
needs_triage
ansibot
added
the
stale_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a series of refactorings split into separate, fairly simple, commits for easier review. The benefits are:
PlayIteratorcode is being removed.HostStatecopying this PR introduces it might be interesting to see as well.PlayIteratorand should not be visible to its users.There are more things to improve, I have mentioned some of them in FIXMEs/TODOs but this isn't small as-is so leaving them for next time.
ISSUE TYPE
ADDITIONAL INFORMATION
Iterating through
Nnested blocks, each block has one task and a nested block, the most nested block is being failed.Before:
0.00024080276489257812 seconds, 10 blocks
0.004384040832519531 seconds, 50 blocks
0.9080429077148438 seconds, 350 blocks
19.866453170776367 seconds, 992 blocks (I believe 992 was a limit for
develto handle)After:
0.00009512901306152344 seconds, 10 blocks
0.0005481243133544922 seconds, 50 blocks
0.01589512825012207 seconds, 350 blocks
0.11786723136901855 seconds, 992 blocks