Fix Creating user directory using tilde always reports "changed" #83113
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
Akasurde
requested changes
Apr 22, 2024
webknjaz
added
the
ci_verified
ansibot
added
stale_review
|
@Akasurde Hi, thanks for the code review, I have applied changes you have suggested. I am not sure as to why the tests are failing on FreeBSD, I dont have that locally, I will try to look into it on the weekend or something by trying to get a VM with FreeBSD on it and run the ansible tests. |
mkrizek
removed
the
needs_triage
webknjaz
added
the
ci_verified
ansibot
added
the
stale_ci
ansibot
removed
ci_verified
|
its failing because the user 'doesnotmatter' already exists, revert back to 'bob'. |
|
@bcoca Hi, the reason why i changed to 'doesnotmatter' is because 'bob' was failiing aswell, the playbook was giving back showing that changed is false which is suspicous,so I thought 'bob' might already exist. It still doesnot explain why its failing on the FreeBSD regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes the issue of when Creating user directory using tilde, ansible always reports "changed"(#82490). along with an integration test to prevent regression. Fixed this issue through changing the spec from 'string' to 'path' for shell. This allowed for auto expansion of the tilde in user provided shell variable.
Fixes #82490
ISSUE TYPE
ADDITIONAL INFORMATION