Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.9] find - set proper default based on use_regex (#73961) #73966

Merged
merged 2 commits into from Apr 5, 2021

Commits on Mar 19, 2021

  1. [stable-2.9] find - set proper default based on use_regex (ansible#73961

    )
    
    When using "use_regex: yes" and setting an excludes: without
    specifying a pattern: the existing code passes the file-glob '*' to
    the regex matcher.  This results in an internal invalid-regex
    exception being thrown.
    
    This maintains the old semantics of a default match-all for pattern:
    but switches the default to '.*' when use_regex is specified.
    
    The code made sense as-is before excludes: was added (2.5).  In that
    case, it made no sense to set use_regex but *not* set a pattern.
    However, with excludes: it now makes sense to only want to exclude a
    given regex but not specify a specific matching pattern.
    
    Closes: ansible#50067
    
    * moved change to new location
    added changelog
    
    * Update lib/ansible/modules/find.py
    
    Co-authored-by: Ian Wienand <iwienand@redhat.com>.
    (cherry picked from commit 089d0a0)
    
    Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
    bcoca authored and samdoran committed Mar 19, 2021
    Copy the full SHA
    6855b46 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Update fix_find_default.yml

    relrod committed Apr 5, 2021
    Copy the full SHA
    2f826be View commit details
    Browse the repository at this point in the history