Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.10] find - set proper default based on use_regex (#73961) #73964

Closed
wants to merge 2 commits into from
Closed

[stable-2.10] find - set proper default based on use_regex (#73961) #73964

wants to merge 2 commits into from

Conversation

samdoran
Copy link
Contributor

SUMMARY

Backport of #73961 for Ansible 2.10.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/find.py

@bcoca @samdoran
[stable-2.10] find - set proper default based on use_regex (ansible#7…
0d1d218 
…3961)

When using "use_regex: yes" and setting an excludes: without
specifying a pattern: the existing code passes the file-glob '*' to
the regex matcher.  This results in an internal invalid-regex
exception being thrown.

This maintains the old semantics of a default match-all for pattern:
but switches the default to '.*' when use_regex is specified.

The code made sense as-is before excludes: was added (2.5).  In that
case, it made no sense to set use_regex but *not* set a pattern.
However, with excludes: it now makes sense to only want to exclude a
given regex but not specify a specific matching pattern.

Closes: ansible#50067

* moved change to new location
added changelog

* Update lib/ansible/modules/find.py

Co-authored-by: Ian Wienand <iwienand@redhat.com>.
(cherry picked from commit 089d0a0)

Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 19, 2021
@ansibot
Copy link
Contributor

ansibot commented Mar 19, 2021

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/find.py:0:0: doc-elements-mismatch: Argument 'excludes' in argument_spec specifies elements as str,but elements is not documented
lib/ansible/modules/find.py:0:0: doc-elements-mismatch: Argument 'paths' in argument_spec specifies elements as str,but elements is not documented
lib/ansible/modules/find.py:0:0: doc-elements-mismatch: Argument 'patterns' in argument_spec specifies elements as str,but elements is not documented
test/sanity/ignore.txt:110:1: A100: Ignoring 'parameter-list-no-elements' on 'lib/ansible/modules/find.py' is unnecessary

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 19, 2021
@samdoran
Copy link
Contributor Author

This depends on a backport of #70139.

@samdoran
Copy link
Contributor Author

Depends on #73970. Might need a rebase after #73970 is merged.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 27, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 5, 2021
@relrod
Copy link
Member

relrod commented Apr 5, 2021

Might need a rebase after #73970 is merged.

How'd you know? :)

@relrod
Copy link
Member

relrod commented Apr 5, 2021

Actually this is a dupe of #73965, will fix conflict there.

@relrod relrod closed this Apr 5, 2021
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 19, 2021
@ansible ansible locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samdoran @ansibot @relrod @sivel @bcoca