Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find fix #73961

Merged
merged 3 commits into from Mar 19, 2021
Merged

Find fix #73961

merged 3 commits into from Mar 19, 2021

Commits on Mar 19, 2021

  1. find: set pattern to default regex when use_regex specified 

    When using "use_regex: yes" and setting an excludes: without
specifying a pattern: the existing code passes the file-glob '*' to
the regex matcher.  This results in an internal invalid-regex
exception being thrown.

This maintains the old semantics of a default match-all for pattern:
but switches the default to '.*' when use_regex is specified.

The code made sense as-is before excludes: was added (2.5).  In that
case, it made no sense to set use_regex but *not* set a pattern.
However, with excludes: it now makes sense to only want to exclude a
given regex but not specify a specific matching pattern.

Closes: ansible#50067
    @ianw @bcoca
    ianw authored and bcoca committed Mar 19, 2021
    Copy the full SHA
    87b0513 View commit details
    Browse the repository at this point in the history

  2. moved change to new location 

    added changelog
    @bcoca
    bcoca committed Mar 19, 2021
    Copy the full SHA
    8a46adc View commit details
    Browse the repository at this point in the history

  3. Update lib/ansible/modules/find.py 

    Co-authored-by: Sam Doran <sdoran@redhat.com>
    @bcoca @samdoran
    bcoca and samdoran committed Mar 19, 2021
    Copy the full SHA
    492deab View commit details
    Browse the repository at this point in the history