Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt at reverting CVE-2020-1736 changes [2.10] #71514

Merged
merged 8 commits into from Sep 1, 2020
Merged

Attempt at reverting CVE-2020-1736 changes [2.10] #71514

merged 8 commits into from Sep 1, 2020

Conversation

relrod
Copy link
Member

@relrod relrod commented Aug 28, 2020

@relrod
Revert atomic_move changes
9088012 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
add note about mode reverts in porting guide
2523c11 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
changelog
4238d23 
Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 28, 2020
acozine
acozine reviewed Aug 28, 2020
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @relrod. This looks good, I put in a couple of suggestions.

docs/docsite/rst/porting_guides/porting_guide_base_2.10.rst Show resolved Hide resolved
docs/docsite/rst/porting_guides/porting_guide_base_2.10.rst Outdated Show resolved Hide resolved
@relrod relrod marked this pull request as ready for review August 28, 2020 20:38
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 28, 2020
@relrod
nuke tests
1ff7386 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
missed part of the revert
f374607 
Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 28, 2020
@relrod
re-add doc suggestions
156b8ac 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod relrod changed the title Attempt at reverting CVE-2020-1736 changes Attempt at reverting CVE-2020-1736 changes [2.10] Aug 28, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 31, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Aug 31, 2020
@relrod relrod merged commit 9a48ffd into ansible:stable-2.10 Sep 1, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Sep 1, 2020
@ansible ansible locked and limited conversation to collaborators Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

@samdoran samdoran Awaiting requested review from samdoran

@nitzmahone nitzmahone Awaiting requested review from nitzmahone

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@relrod @acozine @sivel @ansibot