native types: literal_eval all the things #68938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned.
ansibot
added
affects_2.10
|
@mattclay When distros update Jinja2 from 2.11.1 to 2.11.2 |
This comment has been minimized.
This comment has been minimized.
ansibot
added
needs_revision
sivel
approved these changes
Apr 14, 2020
ansibot
added
core_review
mkrizek
removed
the
needs_triage
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Apr 20, 2020
With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned. (cherry picked from commit acdc9eb)
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Apr 20, 2020
With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned. (cherry picked from commit acdc9eb)
bcoca
pushed a commit
to bcoca/ansible
that referenced
this pull request
Apr 22, 2020
With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned.
bcoca
pushed a commit
to bcoca/ansible
that referenced
this pull request
Apr 28, 2020
With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned.
mattclay
pushed a commit
that referenced
this pull request
May 6, 2020
* native types: literal_eval all the things (#68938) With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned. (cherry picked from commit acdc9eb) * Fix tests
mattclay
added a commit
to mattclay/ansible
that referenced
this pull request
May 7, 2020
ansible#69044)" This reverts commit 70b4ce5.
mattclay
added a commit
that referenced
this pull request
May 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
With pallets/jinja#1190 merged our short-circuit
is no longer valid (has it ever been?) as now data like ' True ' may go
through our ansible_native_concat function as opposed to going through
intermediate call to Jinja2's native_concat before. Now we need to always
send data through literal_eval to ensure native types are returned.
ISSUE TYPE
COMPONENT NAME
lib/ansible/template/native_helpers.py