Restrict setuptools on Python 2 to make CI work again #66405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
WIP
felixfontein
changed the title
ansibot
added
core_review
webknjaz
reviewed
Jan 13, 2020
| openshift | ||
|
|
||
| # setuptools 45.0.0 no longer works with Python 2 | ||
| setuptools<45.0.0 ; python_version < '3' |
There was a problem hiding this comment.
Suggested change
| setuptools<45.0.0 ; python_version < '3' | |
| setuptools<45; python_version < "3.0" | |
| setuptools; python_version >= "3.0" |
There was a problem hiding this comment.
I've updated the first line.
Why should setuptools also be specified for Python >= 3.0? The test needs openshift; I only added setuptools because somewhere in the dependencies of openshift, a newer setuptools is mentioned than is currently installed.
| name: | ||
| - distribute | ||
| # setuptools 45.0.0 no longer works with Python 2 | ||
| - setuptools<45.0.0 |
There was a problem hiding this comment.
Suggested change
| - setuptools<45.0.0 | |
| - setuptools<45; python_version < "3.0" |
There was a problem hiding this comment.
The task is contained in a block with when: ansible_python.version.major == 2.
ansibot
removed
the
needs_triage
|
Closing in favor of #66426. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #66401.
ISSUE TYPE
COMPONENT NAME
test/integration/targets/pip/tasks/pip.yml
test/integration/targets/inventory_kubevirt_conformance/runme.sh