Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.8] docker_network: fix multiple subnet (of same IP version) idempotence #66116

Merged
merged 1 commit into from
Jan 10, 2020
Merged

[2.8] docker_network: fix multiple subnet (of same IP version) idempotence #66116

merged 1 commit into from
Jan 10, 2020

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Backport of #65839 to stable-2.8.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_network

@felixfontein
docker_network: fix multiple subnet (of same IP version) idempotence (a…
debab10 
…nsible#65839)

* Fix multiple subnet (of same IP version) idempotence for docker_network.

* Add changelog.

* Unit tests no longer make sense, since the part of the code they test has been removed.

* Re-add CIDR validation. Move it to better position (module setup instead of idempotence check).

* Update changelog.

* Only run new tests on VM test images.

* Actually do what is documented. Especially since an empty object is a valid value for aux_addresses.

(cherry picked from commit 17ef253)
@ansibot
Copy link
Contributor

ansibot commented Dec 29, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @chouseknecht @danihodovic @dariko @jwitko @kassiansun @keitwb @olsaki @tbouvet
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Dec 29, 2019
@WojciechowskiPiotr
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jan 4, 2020
@mattclay mattclay merged commit 519846a into ansible:stable-2.8 Jan 10, 2020
@felixfontein felixfontein deleted the backport/2.8/65839 branch January 11, 2020 14:12
@ansible ansible locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibot @WojciechowskiPiotr @mattclay