jinja 2.10 compat: add missing built-in tests

[jamescassell]

SUMMARY

fixed ansible template failures on older jinja due to missing built-in tests

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

jinja tests

ADDITIONAL INFORMATION

Playbooks and roles written on ansible 2.8 on a modern would fail if run with ansible 2.8 on RHEL 7 due to missing tests on that platform.

relevant jinja PR: pallets/jinja#665

[ansibot]

The test ansible-test sanity --test pep8 [explain] failed with 17 errors:

lib/ansible/plugins/test/compat_jinja_2_10.py:14:1: E302: expected 2 blank lines, found 1
lib/ansible/plugins/test/compat_jinja_2_10.py:22:1: E302: expected 2 blank lines, found 1
lib/ansible/plugins/test/compat_jinja_2_10.py:29:18: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:30:18: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:31:18: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:32:23: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:33:18: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:34:18: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:35:17: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:36:18: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:38:18: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:39:18: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:40:17: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:41:18: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:42:24: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:43:18: E241: multiple spaces after ':'
lib/ansible/plugins/test/compat_jinja_2_10.py:44:18: E241: multiple spaces after ':'

click here for bot help

[felixfontein]

Would be nice to have that. I had to add a local test plugin for some integration tests to get them working with RHEL7 (like https://github.com/ansible/ansible/blob/devel/test/integration/targets/openssl_csr_info/test_plugins/jinja_compatibility.py).

[samdoran]

Per discussion in the IRC meeting today, please add a test that only uses this if the Jinja version is missing these tests.

[samdoran]

Please add integration tests.

[samdoran]

I'm not sure if this is compatible with the GPLv3 we use in Ansible.

[BerkhanBerkdemir]

Jijna itself is licensed with BSD 3-Clause (new BSD?) [0].

[0]: https://github.com/pallets/jinja/blob/master/LICENSE.rst

[jamescassell]

I'm not sure if this is compatible with the GPLv3 we use in Ansible

Looked it up: https://en.m.wikipedia.org/wiki/License_compatibility#GPL_compatibility

Many of the most common free-software licenses, especially the permissive licenses, such as the original MIT/X license, BSD licenses (in the three-clause and two-clause forms, though not the original four-clause form), MPL 2.0, and LGPL, are GPL-compatible.

Hence, I can apply the GPLv3 label of it helps get it merged.

[ansibot]

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/user_guide/intro_inventory.rst:183:0: duplicate-label: duplicate label variables_in_inventory, other instance in /root/ansible/docs/docsite/rst/user_guide/playbooks_variables.rst

click here for bot help

[jamescassell]

bot_status

[ansibot]

Components

changelogs/fragments/compat-jinja-2.10-test.yml
support: community
maintainers:

lib/ansible/plugins/test/compat_jinja_2_10.py
support: core
maintainers:

lib/ansible/plugins/test/compat_jinja_2_11.py
support: core
maintainers:

test/integration/targets/test_core/tasks/main.yml
support: community
maintainers:

Metadata

waiting_on: jamescassell
changes_requested_by: samdoran
needs_info: False
needs_revision: True
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:
automerge: automerge shipit test failed

click here for bot help

[samdoran]

Rather than adding these directly to Ansible, use the sivel.jinja2 collection.

After the 2.10 release, we will look at making that an officially supported collection. This would allow us to update the Jinja filters and tests much faster than if we add this directly to ansible-base.

To discuss this further, please reach out on IRC or the mailing list:

   * IRC: #ansible-devel on irc.freenode.net  
   * mailing list: https://groups.google.com/forum/#!forum/ansible-devel