Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.9] Pin urllib3 version for k8s test #62636

Closed
wants to merge 1 commit into from
Closed

[stable-2.9] Pin urllib3 version for k8s test #62636

wants to merge 1 commit into from

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Sep 20, 2019

urllib3-1.25.4 breaks k8s due to this bug:
urllib3/urllib3#1682
(cherry picked from commit d3dfea9)

Co-authored-by: Toshio Kuratomi a.badger@gmail.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@abadger
[stable-2.9] Pin urllib3 version for k8s test
bcc2d8d 
urllib3-1.25.4 breaks k8s due to this bug:
urllib3/urllib3#1682
(cherry picked from commit d3dfea9)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
@ansibot
Copy link
Contributor

ansibot commented Sep 20, 2019

cc @chouseknecht @fabianvf @flaper87 @maxamillion @willthames
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. clustering Clustering category community_review In order to be merged, this PR must follow the community review workflow. k8s needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 20, 2019
@willthames
Copy link
Contributor

Should we pin to >=1.25.5 - seems to be fixed there, according to the linked issue?

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 20, 2019
@abadger
Copy link
Contributor Author

abadger commented Sep 20, 2019

urllib3 was updated with a fix. So we shouldn't have to pin an old version anymore

@abadger abadger closed this Sep 20, 2019
@abadger abadger deleted the backport-d3dfea9-stable-2.9 branch September 20, 2019 15:19
@ansible ansible locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. clustering Clustering category community_review In order to be merged, this PR must follow the community review workflow. k8s support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abadger @ansibot @willthames