docker_swarm_service: Documentation fixes #50861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
|
The test |
ansibot
added
ci_verified
ansibot
removed
ci_verified
|
ready_for_review |
ansibot
added
community_review
changelogs/fragments/50861-docker_swarm_service-documentation-fixes.yml
Outdated
Show resolved
Hide resolved
ansibot
removed
the
needs_triage
|
Anyway, you might also be interested in the Ansible Docker WG; see ansible/community#408 for some infos. Feel free to post ideas there or just subscribe to it to find out what's going on. |
felixfontein
suggested changes
Jan 14, 2019
ansibot
added
needs_revision
|
@hannseman Thank you for this improvement |
felixfontein
pushed a commit
to felixfontein/ansible
that referenced
this pull request
Jan 14, 2019
* Describe labels and container_labels correctly * Clarify reserve_memory and limit_memory docs * Remove default from container_labels doc * Remove trailing whitespace * Document min api version for configs and secrets * Add changelog fragment * Specify type on labels and container_labels * Consolidate required API version descriptions * Update reserve and limit memory docs * Use correct power-of-two units * Remove description about limit_memory minimum 4mb (cherry picked from commit 644057e)
|
Thanks everyone! I created a backport PR in #50873. |
abadger
pushed a commit
that referenced
this pull request
Jan 14, 2019
* Describe labels and container_labels correctly * Clarify reserve_memory and limit_memory docs * Remove default from container_labels doc * Remove trailing whitespace * Document min api version for configs and secrets * Add changelog fragment * Specify type on labels and container_labels * Consolidate required API version descriptions * Update reserve and limit memory docs * Use correct power-of-two units * Remove description about limit_memory minimum 4mb (cherry picked from commit 644057e)
knumskull
pushed a commit
to knumskull/ansible
that referenced
this pull request
Jan 21, 2019
* Describe labels and container_labels correctly * Clarify reserve_memory and limit_memory docs * Remove default from container_labels doc * Remove trailing whitespace * Document min api version for configs and secrets * Add changelog fragment * Specify type on labels and container_labels * Consolidate required API version descriptions * Update reserve and limit memory docs * Use correct power-of-two units * Remove description about limit_memory minimum 4mb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes three issues in the documentation.
secretsandconfigs.labelsandcontainer_labelsare described as they accept lists but in reality they expect dicts.limit_memoryandreserve_memorydescribes that they accept values in "MB" but in reality it is in bytes if not suffixed by unit identifiers.ISSUE TYPE
COMPONENT NAME
docker_swarm_service