Test integration of loop and until options #44927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
webknjaz
removed
the
needs_triage
ansibot
added
the
needs_revision
webknjaz
force-pushed
the
testing/loop-until-integration
branch
2 times, most recently
from
9f77f99
to
fc530c1
Compare
This comment has been minimized.
This comment has been minimized.
mattclay
added
the
ci_verified
webknjaz
force-pushed
the
testing/loop-until-integration
branch
from
fc530c1
to
2a28eba
Compare
ansibot
removed
the
ci_verified
webknjaz
force-pushed
the
testing/loop-until-integration
branch
6 times, most recently
from
1920fc3
to
7ebe8f6
Compare
ansibot
added
needs_revision
webknjaz
force-pushed
the
testing/loop-until-integration
branch
from
bfa7d1f
to
b4e09df
Compare
ansibot
added
the
support:core
mattclay
previously requested changes
Sep 1, 2018
webknjaz
force-pushed
the
testing/loop-until-integration
branch
from
64d6099
to
16c7893
Compare
ansibot
removed
needs_revision
webknjaz
force-pushed
the
testing/loop-until-integration
branch
from
2ca5c19
to
533b592
Compare
This was referenced Sep 2, 2018
ansibot
added
the
stale_ci
ansibot
added
the
community_review
|
is this still something we should merge or should we close at this point? |
|
@bcoca when I first created it, I recall folks didn't want to merge this because there was no clear decision how this should work. We agreed that it'd be a demo for how it actually works. |
|
One of the things blocking the merge of #43128 is the current lack of testing for the behaviour of until/retries. While this isn't a comprehensive set of until/retries tests it does improve the current situation and covers many of the loop related scenarios for until. What's the argument against merging this? I don't see any open review items, just a lack of cores adding a final +1. |
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
ansibot
added
collection
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ansibot
added
needs_revision
This is needed for split controller/remote
ansibot
added
community_review
clementmartin
pushed a commit
to clementmartin/ansible
that referenced
this pull request
Nov 30, 2021
Ref ansible#44741 Ref ansible/proposals#140 * Replace select filter with a more portable thing * Add context This is needed for split controller/remote Co-authored-by: Sam Doran <sdoran@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
loop+untilwork well together now. @abadger asked me to add tests for this.Ref #44741
Ref ansible/proposals#140
SUMMARY
ISSUE TYPE
COMPONENT NAME
loop, until
ANSIBLE VERSION
ADDITIONAL INFORMATION