Added nano_cpus parameter in the docker_container.py file.

[amolkahat]

SUMMARY

Added nano_cpus parameter in the docker_container.py file.

Fixes: #34320

Signed-off-by: Amol Kahat akahat@redhat.com

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

docker_container

ANSIBLE VERSION

ansible 2.6.0

[ansibot]

cc @chouseknecht @cove @dusdanig @jctanner @joshuaconner @kassiansun @softzilla @zfil
click here for bot help

[benbro]

nano_cpus:

Why is it called "nano_cpus"? What does nano means?
moby/moby#24713 (comment)

    description:
        - Specify how much CPU resources a container can use.
    default: 0

What are the units? Is it between 0-1 or 0-100% or 0-num-cpus?

--cpus=value option is much simpler:

Specify how much of the available CPU resources a container can use.
For instance, if the host machine has two CPUs and you set --cpus="1.5",
the container is guaranteed at most one and a half of the CPUs.
This is the equivalent of setting --cpu-period="100000" and --cpu-quota="150000".
Available in Docker 1.13 and higher.

[amolkahat]

@benbro In the docker-py library it is mentioned as nano_cpus. As of this reference, I took it as a nano_cpus.

If you want I'll update it to cpus.

[benbro]

@amolkahat there are several ways to limit CPU with the docker API. This blog says:

Specifying cpu usage in nanoseconds for a user is sometimes hard to determine when you want to do simple tasks such as limiting a container to one core.

So it's not just changing the name but the way it works.

[ansibot]

cc @felixfontein
click here for bot help

[felixfontein]

I think we should offer something like --cpu.

About implementing this: I noticed that nano_cpu is missing in the update() function. So maybe we should use cpu_period and cpu_quota, as described in the --cpu documentation.

[leandropadua]

Although the name says "nano", it would be interesting to tell the unit. In this case is 1e-9.

[ansibot]

cc @akshay196 @danihodovic @dariko @jwitko @tbouvet
click here for bot help

[gundalow]

Hi,
This PR seems to have gotten stuck, so we are going to close it. We like to include community contributions, so this is a difficult call for us. Here's why we're closing this one:

• Given the discussion in Docker Agenda/Task list community#408 (comment)
• Redesign needed
• It was created from an old version of the code
• We want to clear out the backlog so it's easier to find bug fixes
• There haven't been any comments or other activity in a long time

If you're the PR author, and you want to start the conversation back up, please:

• reopen the PR and
• rebase the branch

If you're a community member, and you want to see this change merged, please:

• Create a new PR and
• Reference this author in the git commit & PR and
• Reference this PR in the new PR

If you've like to help with the Docker modules please comment on the Docker Agenda/Task List

How to rebase a branch: https://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html
How to communicate with the Ansible community: https://docs.ansible.com/ansible/devel/community/communication.html
How to contribute to Ansible: https://docs.ansible.com/ansible/devel/community/index.html

needs_info