fix parameters passed as string that should be integer #36818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
azure
bugfix_pull_request
cloud
committer_review
|
shipit |
|
bot_status |
Componentslib/ansible/modules/cloud/azure/azure_rm_deployment.py Metadatawaiting_on: ansible |
ansibot
added
shipit
|
ready_for_review |
Akasurde
removed
the
needs_triage
ansibot
added
bug
jborean93
reviewed
Mar 7, 2018
| # this is to fix issue #35536 -- it's impossible to pass int parameters | ||
| if self.parameters and self.template: | ||
| for k in self.parameters: | ||
| if self.template['parameters'][k]['type'] == "int": |
There was a problem hiding this comment.
So to understand this correctly, the user must specify the type as an int in the parameter definition like so?
- azure_rm_deployment:
template:
parameters:
intFieldParameter:
type: int
value: 123
jborean93
reviewed
Mar 7, 2018
|
agree with @jborean93 . it's necessary to add test to cover the change since azure_rm_deployment module is quite general |
yungezz
reviewed
Apr 28, 2018
| @@ -490,6 +490,12 @@ def deploy_template(self): | |||
| uri=self.template_link | |||
| ) | |||
|
|
|||
| # this is to fix issue #35536 -- it's impossible to pass int parameters | |||
| if self.parameters and self.template: | |||
There was a problem hiding this comment.
pls also help to fix in paremeters_link
ansibot
added
support:core
ansibot
added
support:certified
ansibot
added
needs_revision
ansibot
added
small_patch
shipit
ansibot
added
shipit
|
@zikalino This PR exist conflicting files, Could you help to resolve it? Thanks! |
ansibot
added
needs_rebase
|
closing this, as this is not a good fix, a hack really. it needs to be fixed in ansible core. so closing...……... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes bug #35536
Converts parameters passed as string to int based on template definition.
Note: template has to be specified via template parameter, for example using lookup instead of template_url
ISSUE TYPE
COMPONENT NAME
azure_rm_deployment
ANSIBLE VERSION
2.4
ADDITIONAL INFORMATION