elb_classic_lb: ensure stickiness expiration is an int before comparison - fixes #27309 #27328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-hertel
force-pushed
the
stickiness_0
branch
2 times, most recently
from
37ab78a
to
bf682aa
Compare
ansibot
added
affects_2.4
abadger
reviewed
Jul 26, 2017
| @@ -1063,7 +1063,10 @@ def select_stickiness_policy(self): | |||
| if 'expiration' not in self.stickiness: | |||
| self.module.fail_json(msg='expiration must be set when type is loadbalancer') | |||
|
|
|||
| expiration = self.stickiness['expiration'] if self.stickiness['expiration'] is not 0 else None | |||
| try: | |||
| expiration = self.stickiness['expiration'] if int(self.stickiness['expiration']) else None | |||
There was a problem hiding this comment.
Do you need expiration to be an int type as well or is it okay if it is a string repesentation (like: "10" )
There was a problem hiding this comment.
ie: if self.stickiness['expiration'] is the string "10", the change being made does the comparison of self.stickiness['expiration'] as the int 10, but the variable expiration is set to the string "10".
There was a problem hiding this comment.
Thanks for the review. String representation works as expected. The comparison casts them to strings.
abadger
removed
the
needs_triage
|
Cool. +1 to merge.
|
ansibot
added
the
stale_ci
ryansb
approved these changes
Aug 8, 2017
ansibot
removed
the
stale_ci
|
merged to devel. Feel free to cherry-pick if you think it's needed in 2.3.x. |
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Expiration should be an int. Fixes #27309
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/cloud/amazon/elb_classic_lb.py
ANSIBLE VERSION