azure_rm_securitygroup: allow string priority #23343
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Due to #9362 Ansible jinja filters fails to convert strings to integers in complex objects scenario and
azure_rm_securitygroup
do not follow best practices for converting strings to integers in arguments where possible (descibed here #17992 (comment)), so if pass string value like '123' topriority
argument - I get an error:I fix that by parsing
priority
if it have type string.Plus I fix false
changed: True
for scenario wheresource_port_range
ordestination_port_range
just single ports,compare_rules
function compared strings with integers, which always led to false changed.Tested with Ansible 2.3.0rc3.
ISSUE TYPE
COMPONENT NAME
azure_rm_securitygroup
ANSIBLE VERSION