[Backport 2.8] gitlab_runner: fix idempotency for shared runners (#65546

) * gitlab_runner: fix idempotency for shared runners (#65176) * add changelog
ansible · Jan 10, 2020 · fc9d6ea · fc9d6ea
1 parent 11dd391
commit fc9d6ea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/changelogs/fragments/65176-gitlab-runner-idempotency.yaml b/changelogs/fragments/65176-gitlab-runner-idempotency.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+  - gitlab_runner - fix idempotency for shared runner
diff --git a/lib/ansible/modules/source_control/gitlab_runner.py b/lib/ansible/modules/source_control/gitlab_runner.py
@@ -258,10 +258,10 @@ def updateRunner(self, runner, arguments):
     @param description Description of the runner
     '''
     def findRunner(self, description):
-        runners = self._gitlab.runners.list(as_list=False)
+        runners = self._gitlab.runners.all(as_list=False)
         for runner in runners:
-            if (runner.description == description):
-                return self._gitlab.runners.get(runner.id)
+            if (runner['description'] == description):
+                return self._gitlab.runners.get(runner['id'])
 
     '''
     @param description Description of the runner