Skip to content

Commit

Permalink
[2.8] debconf: add a note about no_log usage (#70755)
Browse files Browse the repository at this point in the history
debconf module exposes sensitive information to logs, console.
Add a note to user about using no_log=True to hide such
information from console.

Fixes: #32386

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 84b4387)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 9b9bc11)
  • Loading branch information
Akasurde committed Aug 6, 2020
1 parent f6d5d54 commit 7b8a66f
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
2 changes: 2 additions & 0 deletions changelogs/fragments/32386_debconf_password.yml
@@ -0,0 +1,2 @@
minor_changes:
- debconf - add a note about no_log=True since module might expose sensitive information to logs (https://github.com/ansible/ansible/issues/32386).
12 changes: 11 additions & 1 deletion lib/ansible/modules/system/debconf.py
Expand Up @@ -25,6 +25,7 @@
Use 'debconf-show <package>' on any Debian or derivative with the package
installed to see questions/settings available.
- Some distros will always record tasks involving the setting of passwords as changed. This is due to debconf-get-selections masking passwords.
- It is highly recommended to add I(no_log=True) to task while handling sensitive information using this module.
requirements:
- debconf
- debconf-utils
Expand All @@ -43,6 +44,7 @@
vtype:
description:
- The type of the value supplied.
- It is highly recommended to add I(no_log=True) to task while specifying I(vtype=password).
- C(seen) was added in Ansible 2.2.
type: str
choices: [ boolean, error, multiselect, note, password, seen, select, string, text, title ]
Expand All @@ -68,7 +70,7 @@
value: fr_FR.UTF-8
vtype: select
- name: set to generate locales
- name: Set to generate locales
debconf:
name: locales
question: locales/locales_to_be_generated
Expand All @@ -85,6 +87,14 @@
- name: Specifying package you can register/return the list of questions and current values
debconf:
name: tzdata
- name: Pre-configure tripwire site passphrase
debconf:
name: tripwire
question: tripwire/site-passphrase
value: "{{ site_passphrase }}"
vtype: password
no_log: True
'''

from ansible.module_utils._text import to_text
Expand Down

0 comments on commit 7b8a66f

Please sign in to comment.