If the private_ip has been provided for the new network interface it …

…shouldn't also be added to top level parameters for run_instances (#52579) changelog
ansible · Mar 4, 2019 · 4cf7854 · 4cf7854
1 parent 239fb1f
commit 4cf7854
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelogs/fragments/ec2_fix_assigning_private_without_public_ip.yml b/changelogs/fragments/ec2_fix_assigning_private_without_public_ip.yml
@@ -0,0 +1,3 @@
+bugfixes:
+  - ec2 - if the private_ip has been provided for the new network interface it shouldn't also be added to top level
+    parameters for run_instances()
diff --git a/lib/ansible/modules/cloud/amazon/ec2.py b/lib/ansible/modules/cloud/amazon/ec2.py
@@ -1112,7 +1112,7 @@ def create_instances(module, ec2, vpc, override_count=None):
 
             # check to see if we're using spot pricing first before starting instances
             if not spot_price:
-                if assign_public_ip and private_ip:
+                if assign_public_ip is not None and private_ip:
                     params.update(
                         dict(
                             min_count=count_remaining,