Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add team/user access tab to Notification Template #2283

Merged
merged 3 commits into from May 15, 2024

Conversation

ZitaNemeckova
Copy link
Member

No description provided.

@ZitaNemeckova ZitaNemeckova force-pushed the notification_template_rbac_tabs_zita branch from 09a7cc0 to 7dc7b49 Compare May 10, 2024 14:11
@github-actions github-actions bot added the AWX Label to indicate changes relevant to AWX label May 10, 2024
@nixocio nixocio requested a review from vidyanambiar May 10, 2024 17:13
Copy link
Member

@vidyanambiar vidyanambiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 2 suggestions towards making the route paths consistent (#2292)

frontend/awx/main/routes/useAwxNotificationsRoutes.tsx Outdated Show resolved Hide resolved
frontend/awx/main/routes/useAwxNotificationsRoutes.tsx Outdated Show resolved Hide resolved
@ZitaNemeckova ZitaNemeckova force-pushed the notification_template_rbac_tabs_zita branch 2 times, most recently from 65c9dcd to 277a013 Compare May 15, 2024 06:21
ZitaNemeckova and others added 3 commits May 15, 2024 10:21
Co-authored-by: Vidya Nambiar <43621546+vidyanambiar@users.noreply.github.com>
Co-authored-by: Vidya Nambiar <43621546+vidyanambiar@users.noreply.github.com>
@ZitaNemeckova ZitaNemeckova force-pushed the notification_template_rbac_tabs_zita branch from 277a013 to 09863f0 Compare May 15, 2024 08:21
@ZitaNemeckova ZitaNemeckova merged commit 1f070a2 into main May 15, 2024
17 checks passed
@ZitaNemeckova ZitaNemeckova deleted the notification_template_rbac_tabs_zita branch May 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWX Label to indicate changes relevant to AWX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants