Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAP-23770] Fix Provisioning callback and Enable webhook options in WFJT/JT create/edit forms #2273

Merged
merged 3 commits into from May 13, 2024
Merged

[AAP-23770] Fix Provisioning callback and Enable webhook options in WFJT/JT create/edit forms #2273

merged 3 commits into from May 13, 2024

Conversation

jerabekjiri
Copy link
Contributor

Issue: AAP-23770

Also fixes

  • fix default values in webhook forms
  • fix re-generating webhook_key in edit template
  • incorrect webhook_url for workflow job templates

@github-actions github-actions bot added the AWX Label to indicate changes relevant to AWX label May 9, 2024
@jerabekjiri jerabekjiri force-pushed the jt-fix-edit-enabled-options branch from fe01fe0 to 8cc23ce Compare May 9, 2024 17:03
@jerabekjiri jerabekjiri force-pushed the jt-fix-edit-enabled-options branch from 8cc23ce to aa279f0 Compare May 9, 2024 18:28
@jerabekjiri jerabekjiri requested review from marshmalien, AlexSCorey, nixocio and akus062381 and removed request for marshmalien May 9, 2024 19:30
akus062381
akus062381 approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@akus062381 akus062381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@jerabekjiri jerabekjiri merged commit 55c4253 into main May 13, 2024
17 checks passed
@jerabekjiri jerabekjiri deleted the jt-fix-edit-enabled-options branch May 13, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akus062381 akus062381 akus062381 approved these changes

@AlexSCorey AlexSCorey Awaiting requested review from AlexSCorey

@nixocio nixocio Awaiting requested review from nixocio

@marshmalien marshmalien Awaiting requested review from marshmalien

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jerabekjiri @akus062381