Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable kebab dropdown keyboard accessibility #2265

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marshmalien
Copy link
Member

https://issues.redhat.com/browse/AAP-12914

Update to PatternFly's latest implementation of dropdown and remove deprecated implementation. Some breaking changes addressed:

  • Pass dropdown position as Dropdown popperProps
  • Remove <Tooltip> from dropdown items and pass tooltip properties as DropdownItem tooltipProps
  • Pass dropdown item icon as DropdownItem children
  • Replace <DropdownSeparator> with <Divider>
  • Replace linkable dropdown item component prop with to

keyboard

@github-actions github-actions bot added the AFW Ansible Framework label May 8, 2024
@marshmalien marshmalien marked this pull request as draft May 8, 2024 20:34
Copy link
Member

@akus062381 akus062381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it looks good!

@nixocio nixocio requested a review from jamestalton May 10, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AFW Ansible Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants