tests for eda roles #2261
Merged
tests for eda roles #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
EDA
|
@akus062381 @vishsanghishetty @vidyanambiar I didn't create custom command for creating/ deleting the custom roles as it is only going to be used in 3 tests. let me know if you still want me to write a custom command for it |
|
@vidyanambiar not sure why lint is failing, can you help me here? Thanks!! |
|
@appuk Thanks for adding these tests! The linter errors are caused by references to old role interfaces |
akus062381
requested changes
May 8, 2024
appuk
commented
May 8, 2024
appuk
force-pushed
the
eda-custom-role
branch
2 times, most recently
from
247646c
to
04fd71f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAP-21630