Add User/Team tab to AWX projects #2237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZitaNemeckova
force-pushed
the
awx_rbac_tabs_zita
branch
from
eb3c295
to
826e3b1
Compare
|
QA'ed locally, works as expected Project Teams and Users tab
|
vishsanghishetty
approved these changes
May 6, 2024
vidyanambiar
reviewed
May 7, 2024
ZitaNemeckova
force-pushed
the
awx_rbac_tabs_zita
branch
5 times, most recently
from
5d1e486
to
446c552
Compare
vidyanambiar
approved these changes
May 10, 2024
ZitaNemeckova
force-pushed
the
awx_rbac_tabs_zita
branch
from
446c552
to
b5f16fe
Compare
keithjgrant
requested changes
May 10, 2024
There was a problem hiding this comment.
Looks good! I'm recommending a few URL changes to match a discussion @vidyanambiar and I had about making these sorts of URLs more consistent
ZitaNemeckova
force-pushed
the
awx_rbac_tabs_zita
branch
3 times, most recently
from
90862e7
to
c8140d1
Compare
|
@keithjgrant Fixed! Thanks for pointing it out. |
ZitaNemeckova
force-pushed
the
awx_rbac_tabs_zita
branch
6 times, most recently
from
a7ef54b
to
75f8dd3
Compare
keithjgrant
approved these changes
May 21, 2024
|
It looks like the Projects test(s) need to be updated to check for the new tab labels |
ZitaNemeckova
force-pushed
the
awx_rbac_tabs_zita
branch
2 times, most recently
from
e11dc0f
to
46d34e3
Compare
ZitaNemeckova
force-pushed
the
awx_rbac_tabs_zita
branch
from
46d34e3
to
f5881c5
Compare
ZitaNemeckova
force-pushed
the
awx_rbac_tabs_zita
branch
2 times, most recently
from
3b39201
to
b1b8ae2
Compare
ZitaNemeckova
force-pushed
the
awx_rbac_tabs_zita
branch
from
b1b8ae2
to
3b3b8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.