New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create secret management input component #2192
base: main
Are you sure you want to change the base?
Conversation
352031c
to
d881510
Compare
5114ac2
to
8e14583
Compare
requiredFields={requiredFields} | ||
/> | ||
); | ||
} else if (credentialType.kind === 'ssh' && field.id === 'become_method') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be removed...it is an edge case and we should keep this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I'll put that back in. Does this case also have the potential to be an encrypted field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daphnemaeve it will have to manual test that one.
frontend/awx/access/credentials/components/SecretManagementInputField.tsx
Outdated
Show resolved
Hide resolved
f7a863c
to
d821117
Compare
A few more things:
|
Adds button to open secret management wizard for credential types without kind of 'external'.
Before:
After: