Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for team and user access tab for Project #2049

Closed
wants to merge 5 commits into from
Closed

Add tests for team and user access tab for Project #2049

wants to merge 5 commits into from

Conversation

appuk
Copy link
Member

@appuk appuk commented Apr 16, 2024

@github-actions github-actions bot added EDA Label to indicate changes relevant to EDA E2E End-to-end testing labels Apr 16, 2024
@appuk appuk force-pushed the team-access-tests branch 2 times, most recently from 082af88 to 736af52 Compare April 16, 2024 21:45
@appuk appuk changed the title add tests for team access tab Add tests for team and user access tab for Project Apr 16, 2024
@appuk appuk marked this pull request as ready for review April 16, 2024 22:18
@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX CCT Component tests AFW Ansible Framework labels Apr 17, 2024
@github-actions github-actions bot removed AWX Label to indicate changes relevant to AWX CCT Component tests AFW Ansible Framework labels Apr 17, 2024
akus062381
akus062381 reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@akus062381 akus062381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Apurva! When I pulled down your code, and tried running the tests, I noticed several errors showing in VS Code, and the tests themselves would not run. Perhaps there are some adjustments needed before formal review?

@appuk appuk force-pushed the team-access-tests branch 3 times, most recently from 4515e62 to 2270417 Compare May 2, 2024 03:59
@appuk appuk force-pushed the team-access-tests branch 3 times, most recently from 3cc4dbd to c7c914e Compare May 8, 2024 06:26
@appuk
Copy link
Member Author

appuk commented May 15, 2024

closing in favor of #2301

@appuk appuk closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akus062381 akus062381 akus062381 left review comments

Assignees
No one assigned
Labels
E2E End-to-end testing EDA Label to indicate changes relevant to EDA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@appuk @akus062381 @vidyanambiar @mabashian